Optimize load time and TTFX for non-comparison cases. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At this point, TTFX and load time are better than the most recently released version (1.2.2)
```julia-repl
julia> f(expr; old=false, show=false) = eval(Meta.parse(read(`julia $(old ? () : "--project") $(show ? "--trace-compile=stderr" : ()) -E $("a = @Elapsed using Chairmarks; a,@Elapsed @eval $expr")`, String)))
f (generic function with 3 methods)
julia> comp(x) = f(x, old=true) => f(x)
comp (generic function with 1 method)
julia> comp("@b rand evals=1 samples=1")
(0.008823733, 0.038952421) => (0.007316222, 0.033092877)
julia> comp("@b rand hash seconds=.001")
(0.00852394, 0.046460937) => (0.007173346, 0.037048532)
julia> comp("@b rand hash(_) seconds=.001")
(0.00833723, 0.050975096) => (0.007070262, 0.03884667)
julia> comp("@b rand hash evals=1 samples=1")
(0.008731608, 0.042089029) => (0.00729393, 0.03947555)
julia> comp("@b rand hash(_),hash evals=1 samples=1") # This has a major behavior change
(0.009230821, 0.048152574) => (0.007140638, 0.324881723)
```
|
RegressionTests reports that load time is up 50% in this PR and TTFX is down 10x. That's consistent with expected TTFX but much worse for expected load time. Worth looking into before releasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
_benchmark_1frombenchmarkand eliminate keyword argumentsbenchout of_benchmark_1into its own toplevel function_benchmark_2Commits:
@nospecialize; no impact on load time, TTFX from 0.24 to 0.19Comparison of PR to 1.2.2
Comparison to main (2a3a4a9)
TTFX for the new comparison usage is still terrible